From 8c9698c048200a20ef7eea5816892a896c7e0666 Mon Sep 17 00:00:00 2001
From: ManInDark <61268856+ManInDark@users.noreply.github.com>
Date: Mon, 9 Mar 2026 11:53:09 +0100
Subject: [PATCH] fix: remove FormattedNumber

---
 components/CoinBalance.tsx      | 11 ++++-------
 components/CoinsManager.tsx     | 19 +++++--------------
 components/FormattedNumber.tsx  | 16 ----------------
 components/HeaderActions.tsx    | 15 +++++----------
 components/TodayEarnedCoins.tsx |  9 ++-------
 hooks/useCoins.tsx              | 10 +---------
 lib/atoms.ts                    |  8 --------
 7 files changed, 17 insertions(+), 71 deletions(-)
 delete mode 100644 components/FormattedNumber.tsx

diff --git a/components/CoinBalance.tsx b/components/CoinBalance.tsx
index 4d6f78c..4e17c19 100644
--- a/components/CoinBalance.tsx
+++ b/components/CoinBalance.tsx
@@ -1,9 +1,8 @@
 import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card'
-import { Coins } from 'lucide-react'
-import { FormattedNumber } from '@/components/FormattedNumber'
-import { useAtom } from 'jotai'
-import { useTranslations } from 'next-intl'
 import { settingsAtom } from '@/lib/atoms'
+import { useAtom } from 'jotai'
+import { Coins } from 'lucide-react'
+import { useTranslations } from 'next-intl'
 import dynamic from 'next/dynamic'
 
 const TodayEarnedCoins = dynamic(() => import('./TodayEarnedCoins'), { ssr: false })
@@ -21,9 +20,7 @@ export default function CoinBalance({ coinBalance }: { coinBalance: number }) {
           <Coins className="h-12 w-12 text-yellow-400 mr-4" />
           <div className="flex flex-col">
             <div className="flex flex-col">
-              <span className="text-4xl font-bold">
-                <FormattedNumber amount={coinBalance} settings={settings} />
-              </span>
+              <span className="text-4xl font-bold">{coinBalance}</span>
               <div className="flex items-center gap-1">
                 <TodayEarnedCoins longFormat={true} />
               </div>
diff --git a/components/CoinsManager.tsx b/components/CoinsManager.tsx
index c67685a..30b9c5e 100644
--- a/components/CoinsManager.tsx
+++ b/components/CoinsManager.tsx
@@ -1,6 +1,5 @@
 'use client'
 
-import { FormattedNumber } from '@/components/FormattedNumber'
 import { Avatar, AvatarFallback, AvatarImage } from '@/components/ui/avatar'
 import { Button } from '@/components/ui/button'
 
@@ -127,7 +126,7 @@ export default function CoinsManager() {
               <span className="text-2xl animate-bounce hover:animate-none cursor-default">💰</span>
               <div>
                 <div className="text-sm font-normal text-muted-foreground">{t('currentBalanceLabel')}</div>
-                <div className="text-3xl font-bold"><FormattedNumber amount={balance} settings={settings} /> {t('coinsSuffix')}</div>
+                <div className="text-3xl font-bold">{balance} {t('coinsSuffix')}</div>
               </div>
             </CardTitle>
           </CardHeader>
@@ -214,16 +213,12 @@ export default function CoinsManager() {
               {/* Top Row - Totals */}
               <div className="p-4 rounded-lg bg-green-100 dark:bg-green-900">
                 <div className="text-sm text-green-800 dark:text-green-100 mb-1">{t('totalEarnedLabel')}</div>
-                <div className="text-2xl font-bold text-green-900 dark:text-green-50">
-                  <FormattedNumber amount={totalEarned} settings={settings} /> 🪙
-                </div>
+                <div className="text-2xl font-bold text-green-900 dark:text-green-50">{totalEarned} 🪙</div>
               </div>
 
               <div className="p-4 rounded-lg bg-red-100 dark:bg-red-900">
                 <div className="text-sm text-red-800 dark:text-red-100 mb-1">{t('totalSpentLabel')}</div>
-                <div className="text-2xl font-bold text-red-900 dark:text-red-50">
-                  <FormattedNumber amount={totalSpent} settings={settings} /> 💸
-                </div>
+                <div className="text-2xl font-bold text-red-900 dark:text-red-50">{totalSpent} 💸</div>
               </div>
 
               <div className="p-4 rounded-lg bg-pink-100 dark:bg-pink-900">
@@ -236,16 +231,12 @@ export default function CoinsManager() {
               {/* Bottom Row - Today */}
               <div className="p-4 rounded-lg bg-blue-100 dark:bg-blue-900">
                 <div className="text-sm text-blue-800 dark:text-blue-100 mb-1">{t('todaysEarnedLabel')}</div>
-                <div className="text-2xl font-bold text-blue-900 dark:text-blue-50">
-                  <FormattedNumber amount={coinsEarnedToday} settings={settings} /> 🪙
-                </div>
+                <div className="text-2xl font-bold text-blue-900 dark:text-blue-50">{coinsEarnedToday} 🪙</div>
               </div>
 
               <div className="p-4 rounded-lg bg-purple-100 dark:bg-purple-900">
                 <div className="text-sm text-purple-800 dark:text-purple-100 mb-1">{t('todaysSpentLabel')}</div>
-                <div className="text-2xl font-bold text-purple-900 dark:text-purple-50">
-                  <FormattedNumber amount={coinsSpentToday} settings={settings} /> 💸
-                </div>
+                <div className="text-2xl font-bold text-purple-900 dark:text-purple-50">{coinsSpentToday} 💸</div>
               </div>
 
               <div className="p-4 rounded-lg bg-orange-100 dark:bg-orange-900">
diff --git a/components/FormattedNumber.tsx b/components/FormattedNumber.tsx
deleted file mode 100644
index ea3a608..0000000
--- a/components/FormattedNumber.tsx
+++ /dev/null
@@ -1,16 +0,0 @@
-import { formatNumber } from '@/lib/utils/formatNumber'
-import { Settings } from '@/lib/types'
-
-interface FormattedNumberProps {
-  amount: number
-  settings: Settings
-  className?: string
-}
-
-export function FormattedNumber({ amount, settings, className }: FormattedNumberProps) {
-  return (
-    <span className={`break-all ${className || ''}`}>
-      {formatNumber({ amount, settings })}
-    </span>
-  )
-}
diff --git a/components/HeaderActions.tsx b/components/HeaderActions.tsx
index c45890a..3afdb0c 100644
--- a/components/HeaderActions.tsx
+++ b/components/HeaderActions.tsx
@@ -1,13 +1,12 @@
 'use client'
 
-import Link from 'next/link'
-import { useAtom } from 'jotai'
-import { settingsAtom } from '@/lib/atoms'
 import { useCoins } from '@/hooks/useCoins'
-import { FormattedNumber } from '@/components/FormattedNumber'
+import { settingsAtom } from '@/lib/atoms'
+import { useAtom } from 'jotai'
 import { Coins } from 'lucide-react'
-import NotificationBell from './NotificationBell'
 import dynamic from 'next/dynamic'
+import Link from 'next/link'
+import NotificationBell from './NotificationBell'
 import { Profile } from './Profile'
 
 const TodayEarnedCoins = dynamic(() => import('./TodayEarnedCoins'), { ssr: false })
@@ -21,11 +20,7 @@ export default function HeaderActions() {
       <Link href="/coins" className="flex items-center gap-1 sm:gap-2 px-3 py-1.5 bg-white hover:bg-gray-50 dark:bg-gray-700 dark:hover:bg-gray-600 rounded-full transition-colors border border-gray-200 dark:border-gray-600">
         <Coins className="h-5 w-5 text-yellow-500 dark:text-yellow-400" />
         <div className="flex items-baseline gap-1 sm:gap-2">
-          <FormattedNumber
-            amount={balance}
-            settings={settings}
-            className="text-gray-800 dark:text-gray-100 font-medium text-lg"
-          />
+          <span className="text-gray-800 dark:text-gray-100 font-medium text-lg">{balance}</span>
           <div className="hidden sm:block">
             <TodayEarnedCoins />
           </div>
diff --git a/components/TodayEarnedCoins.tsx b/components/TodayEarnedCoins.tsx
index 4ad5db5..5b3eba7 100644
--- a/components/TodayEarnedCoins.tsx
+++ b/components/TodayEarnedCoins.tsx
@@ -1,20 +1,15 @@
-import { useAtom } from 'jotai'
-import { useTranslations } from 'next-intl'
-import { settingsAtom } from '@/lib/atoms'
 import { useCoins } from '@/hooks/useCoins'
-import { FormattedNumber } from '@/components/FormattedNumber'
+import { useTranslations } from 'next-intl'
 
 export default function TodayEarnedCoins({ longFormat }: { longFormat?: boolean }) {
   const t = useTranslations('TodayEarnedCoins')
-  const [settings] = useAtom(settingsAtom)
   const { coinsEarnedToday } = useCoins()
 
   if (coinsEarnedToday <= 0) return <></>;
 
   return (
     <span className="text-md text-green-600 dark:text-green-400 font-medium mt-1">
-      {"+"}
-      <FormattedNumber amount={coinsEarnedToday} settings={settings} />
+      {"+"}{coinsEarnedToday}
       {longFormat ?
         <span className="text-sm text-muted-foreground"> {t('todaySuffix')}</span>
         : null}
diff --git a/hooks/useCoins.tsx b/hooks/useCoins.tsx
index 5a3431f..63f5855 100644
--- a/hooks/useCoins.tsx
+++ b/hooks/useCoins.tsx
@@ -8,7 +8,6 @@ import {
   currentUserIdAtom,
   settingsAtom,
   totalEarnedAtom,
-  totalSpentAtom,
   usersAtom
 } from '@/lib/atoms';
 import { MAX_COIN_LIMIT } from '@/lib/constants';
@@ -30,7 +29,6 @@ export function useCoins(options?: { selectedUser?: string }) {
   const loggedInUserBalance = loggedInUserId ? coins.transactions.filter(transaction => transaction.userId === loggedInUserId).reduce((sum, transaction) => sum + transaction.amount, 0) : 0;
   const [atomCoinsEarnedToday] = useAtom(coinsEarnedTodayAtom);
   const [atomTotalEarned] = useAtom(totalEarnedAtom)
-  const [atomTotalSpent] = useAtom(totalSpentAtom)
   const [atomCoinsSpentToday] = useAtom(coinsSpentTodayAtom);
   const targetUser = options?.selectedUser ? users.find(u => u.id === options.selectedUser) : currentUser
   
@@ -41,7 +39,6 @@ export function useCoins(options?: { selectedUser?: string }) {
   const timezone = settings.system.timezone;
   const [coinsEarnedToday, setCoinsEarnedToday] = useState(0);
   const [totalEarned, setTotalEarned] = useState(0);
-  const [totalSpent, setTotalSpent] = useState(0);
   const [coinsSpentToday, setCoinsSpentToday] = useState(0);
   const [balance, setBalance] = useState(0);
 
@@ -51,7 +48,6 @@ export function useCoins(options?: { selectedUser?: string }) {
       // If the target user is the currently logged-in user, use the derived atom's value
       setCoinsEarnedToday(atomCoinsEarnedToday);
       setTotalEarned(atomTotalEarned);
-      setTotalSpent(atomTotalSpent);
       setCoinsSpentToday(atomCoinsSpentToday);
       setBalance(loggedInUserBalance);
     } else if (targetUser?.id) {
@@ -62,9 +58,6 @@ export function useCoins(options?: { selectedUser?: string }) {
       const totalEarnedVal = calculateTotalEarned(transactions);
       setTotalEarned(roundToInteger(totalEarnedVal));
 
-      const totalSpentVal = calculateTotalSpent(transactions);
-      setTotalSpent(roundToInteger(totalSpentVal));
-
       const spentToday = calculateCoinsSpentToday(transactions, timezone);
       setCoinsSpentToday(roundToInteger(spentToday));
 
@@ -79,7 +72,6 @@ export function useCoins(options?: { selectedUser?: string }) {
     loggedInUserBalance,
     atomCoinsEarnedToday,
     atomTotalEarned,
-    atomTotalSpent,
     atomCoinsSpentToday
   ]);
 
@@ -180,7 +172,7 @@ export function useCoins(options?: { selectedUser?: string }) {
     transactions: transactions,
     coinsEarnedToday,
     totalEarned,
-    totalSpent,
+    totalSpent: calculateTotalSpent(coins.transactions),
     coinsSpentToday
   }
 }
diff --git a/lib/atoms.ts b/lib/atoms.ts
index bdeedc3..b46312f 100644
--- a/lib/atoms.ts
+++ b/lib/atoms.ts
@@ -2,7 +2,6 @@ import {
   calculateCoinsEarnedToday,
   calculateCoinsSpentToday,
   calculateTotalEarned,
-  calculateTotalSpent,
   generateCryptoHash,
   isHabitDue,
   prepareDataForHashing,
@@ -70,13 +69,6 @@ export const totalEarnedAtom = atom((get) => {
   return roundToInteger(value);
 });
 
-// Derived atom for total spent
-export const totalSpentAtom = atom((get) => {
-  const coins = get(coinsAtom);
-  const value = calculateTotalSpent(coins.transactions);
-  return roundToInteger(value);
-});
-
 // Derived atom for coins spent today
 export const coinsSpentTodayAtom = atom((get) => {
   const coins = get(coinsAtom);