From 821f0e9f59c86b3cd7558a76073930a0eb78e366 Mon Sep 17 00:00:00 2001 From: ManInDark <61268856+ManInDark@users.noreply.github.com> Date: Mon, 23 Feb 2026 22:44:30 +0100 Subject: [PATCH] fix(LXC): network deletion --- Makefile | 3 +++ helper.go | 2 +- lxc.go | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 15c92bc..4df61a0 100644 --- a/Makefile +++ b/Makefile @@ -123,3 +123,6 @@ conformance-test-discovery: install test-request: curl -k -H "Authorization: PVEAPIToken=$$PROXMOX_USERNAME=$$PROXMOX_TOKEN" "https://proxmox.mid:8006/api2/json/nodes/proxmox/lxc" | jq curl -k -H "Authorization: PVEAPIToken=$$PROXMOX_USERNAME=$$PROXMOX_TOKEN" "https://proxmox.mid:8006/api2/json/nodes/proxmox/lxc/200/config" | jq + +test-delete: + curl -k -H "Authorization: PVEAPIToken=$$PROXMOX_USERNAME=$$PROXMOX_TOKEN" "https://proxmox.mid:8006/api2/json/nodes/proxmox/lxc/210/config" -X PUT --data "delete=net0,net1,net2" | jq diff --git a/helper.go b/helper.go index 61a683b..01b9485 100644 --- a/helper.go +++ b/helper.go @@ -76,7 +76,7 @@ func authenticatedRequest(method, url, authorization string, urlparams url.Value return nil, err } - slog.Debug("Executed Request", "url", method, "status code", resp.Status, "body", string(data)) + slog.Debug("Executed Request", "url", method, "params", urlparams, "status code", resp.Status, "body", string(data)) return data, nil } diff --git a/lxc.go b/lxc.go index b99b3cb..95ad394 100644 --- a/lxc.go +++ b/lxc.go @@ -305,7 +305,7 @@ func (p *Plugin) UpdateLXC(ctx context.Context, req *resource.UpdateRequest) (*r } toDelete := []string{} - for i := range min(MAX_NETWORK_COUNT, len(desir.Networks)) { + for i := range min(MAX_NETWORK_COUNT, max(len(desir.Networks), len(prior.Networks))) { if i < len(desir.Networks) { urlparams.Add(fmt.Sprintf("net%d", i), desir.Networks[i]) } else {